[automatic failover] Fix misleading timing information for AA scenario test #4303
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes misleading timing information in the Active-Active failover scenario test by ensuring that only commands executed on the failed cluster are counted as failover-related failures.
- Adds a check to determine if a command is being executed on the originally active cluster
- Modifies the failure counting logic to only increment when the command was attempted on the failed cluster
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| int maxTries = 500; | ||
| int retryingDelay = 5; | ||
| while (true) { | ||
| boolean attempToExecuteOnFailedCluster = false; |
There was a problem hiding this comment.
Corrected spelling of 'attemp' to 'attempt'.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.